Thiago Macieira (19 September 2017 16:49)
> The problem with Q_DECL_NOTHROW is that it once added, it cannot be
> removed.  There's also the choice: we choose to add it only to
> functions that (in addition to neevr throwing) are wide contract. So
> we should see it and review that kind of change.

Then I'll remove that from the list (and document that it shouldn't be
filtered out).

> Q_ALWAYS_INLINE, however, has no bearing in ABI. It's a purely
> optimisation feature and can be added or removed at will.

Good - kept.

> Q_REQUIRED_RESULT being moved to the beginning of the line was a very
> restricted change. There was exactly one commit affecting about 20
> functions, that's all.

All the same, if it gets added to a function (rather than repositioned),
does that matter for API reviews ?

        Eddy.
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to