Oh, I'm sorry for the spam! You already renamed error() getter to sockerError() [1], so the issue is not relevant now. It's a bit unfortunate to see such diversity in the API. error() getter seems to be a convention in Qt. I thought that the same convention is to use '-ed' verbs in signal names.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.15&id=94b3dd77f29a00ebbd1efdc66d75f57e1c75b152 On Wed, Feb 5, 2020 at 1:04 PM Alexander Akulich <akulichalexan...@gmail.com> wrote: > > What I'm talking about is to repeat [1] for QAbstractSocket [2] as a > last-minute change for Qt 5.15. > If such a patch is not acceptable for 5.15, is it still acceptable for > Qt 6 (in terms of Qt 5.15/6.0 compatibility policy)? > > I'm going to prepare the patch right now, whether it 'll be accepted > or not. (I hope and expect it to be a small change that is not sad to > drop) > > [1] > https://code.qt.io/cgit/qt/qtbase.git/commit/?id=4672e319e6dd0fbaa986e056e52dbb06d78fcfa5 > [2] https://doc.qt.io/qt-5/qabstractsocket.html#error-1 > > On Wed, Feb 5, 2020 at 12:42 PM Alexander Akulich > <akulichalexan...@gmail.com> wrote: > > > > Hi all, > > > > does the 5.15 feature freeze mean that we can not adjust signal names > > anymore? IIRC it was said that "deprecated-free" code for Qt 5.15 > > will/should be compatible with Qt 6. > > > > IIRC there was an intention to rename > > QAbstractSocket::error(SocketError) signal to errorOccured() to align > > it with the other signals and to remove the overload of > > QAbstractSocket::error() getter, so the API becomes a bit more > > developer-friendly. > > I thought that it was done, but it seems to be not the case. I can > > prepare and submit a patch in a few hours if it is still applicable > > for 5.15. > > > > On Wed, Feb 5, 2020 at 8:43 AM Jani Heikkinen <jani.heikki...@qt.io> wrote: > > > > > > Hi! > > > > > > For this one my reply is similar :D > > > > > > Why this is so important that we should get the exception & go in after > > > FF? We need to delay the Alpha release because of this late addition if > > > we agree to take this in. It seems this shouldn't cause that big delay > > > but you never know... And taking this in between Alpha and beta doesn't > > > sound that well to me either; as written before all known features should > > > be in Alpha... > > > > > > br, > > > Jani > > > > > > > > > ________________________________________ > > > From: Lars Knoll <lars.kn...@qt.io> > > > Sent: Tuesday, February 4, 2020 8:41 PM > > > To: Volker Hilsheimer > > > Cc: Jani Heikkinen; Qt development mailing list; releas...@qt-project.org > > > Subject: Re: [Releasing] [Development] HEADS-UP: Qt 5.15 Feature Freeze > > > is in effect now > > > > > > > On 4 Feb 2020, at 16:56, Volker Hilsheimer <volker.hilshei...@qt.io> > > > > wrote: > > > > > > > >> On 3 Feb 2020, at 06:35, Jani Heikkinen <jani.heikki...@qt.io> wrote: > > > >> > > > >> Hi all, > > > >> > > > >> Qt 5.15 Feature Freeze is in effect now. So no new features in '5.15' > > > >> anymore. Please update Qt 5.15 new features page > > > >> (https://wiki.qt.io/New_Features_in_Qt_5.15) now; it seems to be quite > > > >> empty still... > > > >> > > > >> Target is to publish Qt 5.15 Alpha as soon as possible; Let's see if > > > >> we can get it out already during this week. > > > >> > > > >> API review for Qt 5.15 will start soon as well. Please do reviews > > > >> immediately when available. > > > >> > > > >> br, > > > >> Jani Heikkinen > > > > > > > > > > > > I’ve been struggling a bit more than expected with getting the > > > > implementation of "move a file or directory to the trash" pass CI. It’s > > > > a popular feature request: > > > > > > > > https://bugreports.qt.io/browse/QTBUG-47703 > > > > > > > > The basic implementation and private APIs have been in for a bit, but > > > > required a bit of follow-up, which delayed the merging of the commit > > > > that adds the public API in: > > > > > > > > https://codereview.qt-project.org/c/qt/qtbase/+/287373 > > > > > > +1 from my side. It doesn’t have dependencies on any other code, so it > > > can’t break anything else neither. > > > > > > Cheers, > > > Lars > > > > > > _______________________________________________ > > > Development mailing list > > > Development@qt-project.org > > > https://lists.qt-project.org/listinfo/development _______________________________________________ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
