> On 11. Mar 2020, at 07:48, Richard Weickelt <[email protected]> wrote: > >>> In an ideal world... >>> >>> - Alice opens a pull request on GitHub. >>> - A bot sees the PR and opens a corresponding request on Gerrit. >>> - Bob comments on the Gerrit request. >>> - A bot sees Bob's comment and replicates it to the GitHub PR. >>> - Alice replies (on GitHub) to Bob's comment. >>> - A bot sees Alice's comment and replicates it to Gerrit. >>> >>> ...and so on. >> >> Then Bob asks Alice to make a change in commit, and she has to make >> push -f in her branch. After that, review comments on GitHub are smashed, >> while remain perfectly readable in Gerrit, and Bob can see difference >> between patch versions while Alice cannot. > > There is a github plugin for Gerrit that promises some form of integration: > > https://gerrit.googlesource.com/plugins/github/
I searched a bit and found a sample github pull request, and its associated Gerrit change. https://review.gerrithub.io/c/eclipse/titan.EclipsePlug-ins/+/486885 https://github.com/eclipse/titan.EclipsePlug-ins/pull/572 Looks like all commits inside the PR (2 in this case) + an additional commit for the merge get merged into Gerrit (rather than cherry-picked). Don't know if it's configurable behaviour, somebody would have to play with the plugin. > > It seems to be enabled on gerrithub: > > http://gerrithub.io/ > > "GitHub pull requests > Keep in touch with external users synchronizing > pull requests with reviews." > > "Pull requests with Gerrit > Fetch your GitHub pull requests and upload them > in Gerrit for review. Enable a single point of > validation of the Code Review workflow and keep > your external contributors up-to-date on GitHub." > > I haven't tried it though. Does it work? Maybe there is a project on > https://review.gerrithub.io/ where you can see github PR syncing in action. > > Richard > _______________________________________________ > Development mailing list > [email protected] > https://lists.qt-project.org/listinfo/development _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
