On Wednesday, 11 March 2020 03:48:24 PDT Edward Welbourne wrote: > Matthew Woehlke (10 March 2020 20:24) wrote: > > In an ideal world... > > [snip] > > > Note that I believe nothing needs to be done to "merge" the GitHub PR; > > if the commits become reachable from the target branch, it should > > automatically get marked as "merged". > > Given that gerrit cherry-picks the change submitted onto the branch it's > sent to, the commit the user originally pushed doesn't become reachable. > Will GitHub recognise the cherry-pick as resolving the PR ?
I doubt it. It doesn't recognise when I do that manually. It only recognises when GitHub itself dos the rebase prior to application. All other cases, the PR needs to be closed as if it got rejected. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products _______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
