> A small experiment https://codereview.qt-project.org/c/qt/qtbase/+/742796
This builds fine, but methods are still not inlined :( While I am very fond of working in the Visual Studio IDE, I must say I understand Thiago's POV about the quality of the MSVC compiler. Philippe On Mon, 8 Jun 2026 16:48:06 +0000 Mårten Nordheim via Development <[email protected]> wrote: > A small experiment https://codereview.qt-project.org/c/qt/qtbase/+/742796 > > ________________________________________ > From: Mårten Nordheim <[email protected]> > Sent: Monday, June 8, 2026 17:28 > To: [email protected] > Subject: Re: [Development] MSVC not inlining QRect inline functions (anymore?) > > > Testing this with the inline debugging things from MSVC it is simply listing > the reason for not inlining as 'dllimport check failed'. > So it seems to not inline solely based on it being marked dllimport. > > Could we perhaps make some of these functions export-only? Just remove the > dllimport side of things, only export the symbol. > > Mårten > > ________________________________________ > From: Development <[email protected]> on behalf of Philippe > <[email protected]> > Sent: Monday, June 8, 2026 16:05 > To: [email protected] > Subject: Re: [Development] MSVC not inlining QRect inline functions (anymore?) > > I have just verified that not only QRect, but QPoint, QSize and QMargins are > also affected :( > > QCheckedInt overflow checks only manifest as assertions in debug builds. > Yet, this debug-only feature has a negative impact on the MSVC release > version :( > Not exactly, "Pay Only For What You Use"... > > Philippe > > On Sun, 7 Jun 2026 17:48:33 +0200 > Christian Ehrlicher via Development <[email protected]> wrote: > > > Hi, > > > > I recently found out that none of the QRect inline functions are inlined by > > msvc no matter what compiler options I pass. Tested with recent cl > > (19.51.36244) but also saw this with older msvc2022 compilers. > > Is this known and should/can we do something against this? > > > > > > Christian > > -- Development mailing list > > [email protected] > > https://lists.qt-project.org/listinfo/development > > > -- > Development mailing list > [email protected] > https://lists.qt-project.org/listinfo/development > -- > Development mailing list > [email protected] > https://lists.qt-project.org/listinfo/development -- Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
