From: Grant Likely <[email protected]> Date: Fri, 8 Oct 2010 11:12:10 -0600
> On Fri, Oct 08, 2010 at 12:43:54AM -0700, Andres Salomon wrote: >> >> We need phandle for some exported sparc headers; of.h isn't an >> exported header, and it would be silly to export it when all we >> really need is one or two types from it. Also, later patches >> use phandle in structs that are exported to userspace, so export >> a __kernel_phandle type. >> >> Signed-off-by: Andres Salomon <[email protected]> > > Looks okay to me. I'm build testing it now on powerpc and > microblaze. If davem agrees, then I'll pick it up into my > devicetree-next branch. > > Question though; since sparc userspace is the only user of this, > should the types.h header avoid exposing it on non-sparc? I can't think of anything in Sparc userspace that needs the phandle_t type. In fact I was a bit confused when you asked Andres to expose it to userspace. What I remember from a previous thread is that some other platforms use the type in their DT device-tree building tools or whatever, but they define phandle_t for themselves I remember specifically mentioning sparc has no use for this currently. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
