Uwe Kleine-König writes: > On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote: > > Hi, > > > > Shawn Guo writes: > > > spi_imx_devtype_data has already been driver private data. There is > > > really no need to make a copy in spi_imx_data. Instead, a reference > > > pointer works perfectly fine. > > > > > You obviously overlooked, that the copy is done on purpose to keep > > only the data that is actually needed and discard everything else > > after initialisation. > though you could argue that __devinitdata isn't discarded on modern > systems anyhow (and Shawn's patch takes care of removing that > annotation). > Shawn's comment should probably have reflected that...
Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________ _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
