On Sun, Jan 08, 2012 at 03:32:21PM +0200, Gilad Ben-Yossef wrote:
> on_each_cpu always returns a hard coded return code of zero.
> 
> Removing all tests based on this return value saves run time
> cycles for compares and code bloat for branches.
> 
> Signed-off-by: Gilad Ben-Yossef <[email protected]>
> Acked-by: Peter Zijlstra <[email protected]>
> Reviewed-by: Michal Nazarewicz <[email protected]>
> CC: Will Deacon <[email protected]>
> CC: Peter Zijlstra <[email protected]>
> CC: Paul Mackerras <[email protected]>
> CC: Ingo Molnar <[email protected]>
> CC: Arnaldo Carvalho de Melo <[email protected]>
> CC: Russell King <[email protected]>

Reviewed-by: Russell King <[email protected]>

> CC: Grant Likely <[email protected]>
> CC: Rob Herring <[email protected]>
> CC: [email protected]
> CC: [email protected]
> ---
>  arch/arm/kernel/perf_event.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 5bb91bf..6e9acb7 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -616,7 +616,7 @@ static int __init
>  cpu_pmu_reset(void)
>  {
>       if (cpu_pmu && cpu_pmu->reset)
> -             return on_each_cpu(cpu_pmu->reset, NULL, 1);
> +             on_each_cpu(cpu_pmu->reset, NULL, 1);

There's not much to review here...

Thanks.

>       return 0;
>  }
>  arch_initcall(cpu_pmu_reset);
> -- 
> 1.7.0.4
> 
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to