On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote: > on_each_cpu returns the retunr value of smp_call_function > which is hard coded to 0. > > Refactor on_each_cpu to a void function and the few callers > that check the return value to save compares and branches. > > Signed-off-by: Gilad Ben-Yossef <[email protected]> > Acked-by: Peter Zijlstra <[email protected]> > Reviewed-by: Michal Nazarewicz <[email protected]> > CC: David Airlie <[email protected]> > CC: [email protected] > CC: Benjamin Herrenschmidt <[email protected]> > CC: Paul Mackerras <[email protected]> > CC: Grant Likely <[email protected]> > CC: Rob Herring <[email protected]> > CC: [email protected] > CC: [email protected] > CC: Richard Henderson <[email protected]> > CC: Ivan Kokshaysky <[email protected]> > CC: Matt Turner <[email protected]> > CC: [email protected] > CC: Thomas Gleixner <[email protected]> > CC: Ingo Molnar <[email protected]> > CC: "H. Peter Anvin" <[email protected]> > CC: [email protected] > CC: Tony Luck <[email protected]> > CC: Fenghua Yu <[email protected]> > CC: [email protected] > CC: Will Deacon <[email protected]> > CC: Peter Zijlstra <[email protected]> > CC: Arnaldo Carvalho de Melo <[email protected]> > CC: Russell King <[email protected]>
As there's only one place in the ARM code where we look at the return value, and you've patched that away in patch 1, this looks fine. I've not checked for users outside of arch/arm, so: Acked-by: Russell King <[email protected]> Thanks. _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
