On Fri, Jul 6, 2012 at 11:09 AM, Dong Aisheng <[email protected]> wrote:
> From: Dong Aisheng <[email protected]> > > The General Purpose Registers (GPR) is used to select operating modes for > general features in the SoC, usually not related to the IOMUX itself, > but it does belong to IOMUX controller. > We simply provide an convient API for driver to call to set the general > purpose > register bits if needed. > > Signed-off-by: Dong Aisheng <[email protected]> I have an overall objection to this: I have no idea at all about what's going on, and why this belongs in the pin control subsystem. On the contrary, from the commit description it seems to *not* belong in this subsystem at all. So: exactly what does this register do, and which are the consumers? Notice: nothing at all stops you from mapping the same address range or just this register in some other driver. So the same address range being used is not a reason to have this in this driver, it could very well be handled by drivers/misc/imx-syscon.c or maybe my postulated (but non-existent) drivers/syscon/*. The reason I react against it is that some GPIO drivers already have custom API:s doing pinctrl stuff, and shunning this kind of stuff into the pinctrl subsystem might hide it from the real subsystem where it actually belongs and hinder development of the proper subsystems. Yours, Linus Walleij _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
