On 15 November 2012 19:47, Linus Walleij <[email protected]> wrote: > On Sun, Nov 11, 2012 at 5:39 AM, Viresh Kumar <[email protected]> wrote: > >> From: Shiraz Hashim <[email protected]> >> >> SPEAr platform provides a provision to control chipselects of ARM PL022 >> Prime Cell spi controller through its system registers, which otherwise >> remains under PL022 control which some protocols do not want. >> >> This commit intends to provide the spi chipselect control in software >> over gpiolib interface. Since it is tied to pinctrl, we place it under >> 'drivers/pinctrl/spear/' directory. >> >> spi chip drivers can use the exported gpiolib interface to define their >> chipselect through DT or platform data. >> >> Cc: Linus Walleij <[email protected]> >> Signed-off-by: Shiraz Hashim <[email protected]> >> Reviewed-by: Vipin Kumar <[email protected]> >> Signed-off-by: Viresh Kumar <[email protected]> > > This sure looks good, sorry for the delay. > > Just one question: since this driver is not using any > pinctrl interfaces, why is it under drivers/pinctrl/*? > > Shouldn't it be under drivers/gpio from a technical > point of view? > > I think I'd accept it under drivers/pinctrl/spear/* > if you just want this to keep everything SPEAr-related > in one place though, so enlighten me.
That's because they are controlling few pads. They are not actually gpio's but just pads that we are controlling. That's why we thought they are better in this place. -- viresh _______________________________________________ devicetree-discuss mailing list [email protected] https://lists.ozlabs.org/listinfo/devicetree-discuss
