On Thu, Nov 20, 2014 at 06:02:13AM +0100, Andrew Lunn wrote: > On Wed, Nov 19, 2014 at 08:55:19PM -0500, Jason Cooper wrote: > > Andrew, > > > > On Wed, Nov 19, 2014 at 12:01:36AM +0100, Arnaud Ebalard wrote: > > > > > > As reported by Andrew, the vendor prefix for Seiko Instruments, Inc. > > > S-35390A I2C RTC chip in kirkwood-synology.dtsi has a typo (ssi > > > instead of sii). This patches fixes it. > > > > > > Reported-by: Andrew Lunn <[email protected]> > > > Signed-off-by: Arnaud Ebalard <[email protected]> > > > --- > > > arch/arm/boot/dts/kirkwood-synology.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/kirkwood-synology.dtsi > > > b/arch/arm/boot/dts/kirkwood-synology.dtsi > > > index 811e0971fc58..8be5b2e4626e 100644 > > > --- a/arch/arm/boot/dts/kirkwood-synology.dtsi > > > +++ b/arch/arm/boot/dts/kirkwood-synology.dtsi > > > @@ -266,7 +266,7 @@ > > > > > > s35390a: s35390a@30 { > > > status = "disabled"; > > > - compatible = "ssi,s35390a"; > > > + compatible = "sii,s35390a"; > > > > Should the driver now support both variants for backward compatibility? > > Hi Jason > > This is an i2c device. i2c totally ignores the vendor. It is optional. > So there is no backward compatibility issues.
In this case I think we're probably fine changing it, but your argument is a Linux implementation choice. The BSDs and bootloaders may work differently. Just something to keep in mind with these things. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
