On Monday 14 April 2008 03:42, [EMAIL PROTECTED] wrote: > Author: j16sdiz > Date: 2008-04-14 02:42:33 +0000 (Mon, 14 Apr 2008) > New Revision: 19290 > > Modified: > trunk/freenet/src/freenet/support/math/TrivialRunningAverage.java > Log: > findbugs: synchronization
Wouldn't it be better to synchronize in the copy constructor?
>
>
> Modified: trunk/freenet/src/freenet/support/math/TrivialRunningAverage.java
> ===================================================================
> --- trunk/freenet/src/freenet/support/math/TrivialRunningAverage.java
2008-04-14 02:42:07 UTC (rev 19289)
> +++ trunk/freenet/src/freenet/support/math/TrivialRunningAverage.java
2008-04-14 02:42:33 UTC (rev 19290)
> @@ -40,7 +40,9 @@
> }
>
> public Object clone() {
> - return new TrivialRunningAverage(this);
> + synchronized (this) {
> + return new TrivialRunningAverage(this);
> + }
> }
>
>
>
> _______________________________________________
> cvs mailing list
> [EMAIL PROTECTED]
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
>
>
pgpBY4K4E5mAU.pgp
Description: PGP signature
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
