On Saturday 26 April 2008 04:57, [EMAIL PROTECTED] wrote:
> Author: j16sdiz
> Date: 2008-04-26 03:57:34 +0000 (Sat, 26 Apr 2008)
> New Revision: 19567
> 
> Modified:
>    trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java
> Log:
> use FileChannel.read()/write() in BDBFS
> 
All good stuff, however:
- Don't use allocateDirect() unless you plan to keep the returned ByteBuffer 
around for a long time. They are immobile and therefore hard to garbage 
collect.
- ClosedChannelException, AsynchronousCloseException and 
ClosedByInterruptException should be caught and cause a silent failure for a 
smooth shutdown.

Attachment: pgpTyDDd41dYP.pgp
Description: PGP signature

_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to