On Saturday 19 July 2008 20:38, [EMAIL PROTECTED] wrote: > Author: nextgens > Date: 2008-07-19 19:38:31 +0000 (Sat, 19 Jul 2008) > New Revision: 21270 > > Modified: > trunk/freenet/src/freenet/node/KeyTracker.java > Log: > 1.5ism: replace new Integer(int) by Integer.valueOf(int)
Why not autoboxing? removeByKey(<integer auto-boxed to Integer>) ?
>
> Modified: trunk/freenet/src/freenet/node/KeyTracker.java
> ===================================================================
> --- trunk/freenet/src/freenet/node/KeyTracker.java 2008-07-19 19:21:43 UTC
(rev 21269)
> +++ trunk/freenet/src/freenet/node/KeyTracker.java 2008-07-19 19:38:31 UTC
(rev 21270)
> @@ -567,7 +567,7 @@
> * @throws UpdatableSortedLinkedListKilledException
> */
> private void removeAckRequest(int seqNo) throws
UpdatableSortedLinkedListKilledException {
> - QueuedAckRequest qr =
(QueuedAckRequest)ackRequestQueue.removeByKey(new Integer(seqNo));
> + QueuedAckRequest qr =
(QueuedAckRequest)ackRequestQueue.removeByKey(Integer.valueOf(seqNo));
> if(qr != null) qr.onAcked();
> else
> Logger.normal(this, "Removing ack request twice? Null on
> "+seqNo+"
from "+pn.getPeer()+" ("+TimeUtil.formatTime((int) pn.averagePingTime(), 2,
true)+" ping avg)");
> @@ -584,7 +584,7 @@
> if(resendData.length > Node.PACKET_SIZE)
> pn.getThrottle().notifyOfPacketLost();
> synchronized(packetsToResend) {
> - packetsToResend.add(new Integer(seqNumber));
> + packetsToResend.add(Integer.valueOf(seqNumber));
> }
> pn.node.ps.wakeUp();
> } else {
>
> _______________________________________________
> cvs mailing list
> [EMAIL PROTECTED]
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
>
>
pgplYyK61y0pS.pgp
Description: PGP signature
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
