On Tuesday 05 August 2008 15:31, Julien Cornuwel wrote:
> Matthew Toseland a écrit :
> 
> >> +                  if(trusterScore.getCapacity() > 0) {
> >> +                          newScore += trusterScore.getCapacity() * 
> >> trusterTrust.getValue() / 
100;
> >> +                          if(newRank == -1 || newRank > 
> >> trusterScore.getRank())
> >> +                                  newRank = trusterScore.getRank();
> >
> > Surely this should be || newRank < trusterScore.getRank()? Larger numbers 
=
> > less trusted, right?
> 
> Nope, that code gets the lowest truster's capacity (most trusted),
> different from -1.

You are fetching rank here, not capacity. Lower is better for rank (unless 
it's -1). No?
> 
> > Does the code correctly handle rank upgrades? Downgrades?
> 
> Yes, it does.

Attachment: pgpuvRoZs2C0R.pgp
Description: PGP signature

_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to