On Mon, Oct 20, 2008 at 7:40 PM, Florent Daigniere
<[EMAIL PROTECTED]> wrote:
> Daniel Cheng wrote:
>> On Thu, Oct 16, 2008 at 1:24 AM,  <[EMAIL PROTECTED]> wrote:
>>> Author: xor
>>> Date: 2008-10-15 17:24:04 +0000 (Wed, 15 Oct 2008)
>>> New Revision: 22988
>>>
>>> Modified:
>>>   trunk/freenet/src/freenet/clients/http/FProxyToadlet.java
>>> Log:
>>> Emphasize the link to open Thaw indexes with the Thaw plugin.
>>>
>>> Modified: trunk/freenet/src/freenet/clients/http/FProxyToadlet.java
>>> ===================================================================
>>> --- trunk/freenet/src/freenet/clients/http/FProxyToadlet.java   2008-10-15 
>>> 16:08:52 UTC (rev 22987)
>>> +++ trunk/freenet/src/freenet/clients/http/FProxyToadlet.java   2008-10-15 
>>> 17:24:04 UTC (rev 22988)
>>> @@ -223,15 +223,18 @@
>>>                        
>>> infoboxContent.addChild("p").addChild(e.getHTMLExplanation());
>>>                        infoboxContent.addChild("p", l10n("options"));
>>>                        HTMLNode optionList = infoboxContent.addChild("ul");
>>> -                       HTMLNode option = optionList.addChild("li");
>>> -                       L10n.addL10nSubstitution(option, 
>>> "FProxyToadlet.openAsText", new String[] { "link", "/link" }, new String[] 
>>> { "<a 
>>> href=\""+basePath+key.toString()+"?type=text/plain"+extrasNoMime+"\">", 
>>> "</a>" });
>>> -                       // FIXME: is this safe? See bug #131
>>> +                       HTMLNode option;
>>>
>>>                        if((mimeType.equals("application/x-freenet-index")) 
>>> && 
>>> (core.node.pluginManager.isPluginLoaded("plugins.ThawIndexBrowser.ThawIndexBrowser")))
>>>  {
>>>                                option = optionList.addChild("li");
>>> -                               L10n.addL10nSubstitution(option, 
>>> "FProxyToadlet.openAsThawIndex", new String[] { "link", "/link" }, new 
>>> String[] { "<a href=\""+basePath + 
>>> "plugins/plugins.ThawIndexBrowser.ThawIndexBrowser/?key=" + key.toString() 
>>> + "\">", "</a>" });
>>> +                               L10n.addL10nSubstitution(option, 
>>> "FProxyToadlet.openAsThawIndex", new String[] { "link", "/link" }, new 
>>> String[] { "<b><a href=\""+basePath + 
>>> "plugins/plugins.ThawIndexBrowser.ThawIndexBrowser/?key=" + key.toString() 
>>> + "\">", "</a></b>" });
>>>                        }
>>> +
>>>                        option = optionList.addChild("li");
>>> +                       // FIXME: is this safe? See bug #131
>>
>> bug #131 was marked as resolved-fixed on 2006
>  >
>
> I am not happy about its resolution... Some references would have been
> welcome.

reopen the bug then

--
_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to