On Monday 22 December 2008 03:06, [email protected] wrote: > Author: j16sdiz > Date: 2008-12-22 03:06:33 +0000 (Mon, 22 Dec 2008) > New Revision: 24721 > > Modified: > trunk/freenet/src/freenet/node/PacketSender.java > trunk/freenet/src/freenet/support/PooledExecutor.java > Log: > comment > > Modified: trunk/freenet/src/freenet/node/PacketSender.java > =================================================================== > --- trunk/freenet/src/freenet/node/PacketSender.java 2008-12-22 03:06:08 UTC (rev 24720) > +++ trunk/freenet/src/freenet/node/PacketSender.java 2008-12-22 03:06:33 UTC (rev 24721) > @@ -29,6 +29,9 @@ > * Thread that sends a packet whenever: - A packet needs to be resent immediately - > * Acknowledgments or resend requests need to be sent urgently. > */ > +// j16sdiz (22-Dec-2008): > +// FIXME this is the only class implements Ticker, everbody is using this as > +// a generic task scheduler. Either rename this class, or create another tricker for non-Packet tasks
It's debatable: everything PacketSender does is relatively lightweight, so I
figured we could save a thread. But it probably makes sense to have a
separate Ticker thread.
> public class PacketSender implements Runnable, Ticker {
>
> private static boolean logMINOR;
>
> Modified: trunk/freenet/src/freenet/support/PooledExecutor.java
> ===================================================================
> --- trunk/freenet/src/freenet/support/PooledExecutor.java 2008-12-22
03:06:08 UTC (rev 24720)
> +++ trunk/freenet/src/freenet/support/PooledExecutor.java 2008-12-22
03:06:33 UTC (rev 24721)
> @@ -74,6 +74,7 @@
> // Must create new thread
> if((!fromTicker) &&
> NativeThread.usingNativeCode() && prio >
Thread.currentThread().getPriority()) {
> // Run on ticker
> + // j16sdiz (22-Dec-2008):
> should we queue it? the ticker
is "PacketSender", but it keep busying on non-packet related works
Does it? Unless the job is a FastRunnable, it will just allocate (or more
likely reuse) a pooled thread for the job...
> ticker.queueTimedJob(job,
> jobName, 0, true);
> return;
> }
pgpm3VbwiExaA.pgp
Description: PGP signature
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
