On Sun, Jan 11, 2009 at 7:34 AM, Matthew Toseland
<[email protected]> wrote:
> On Monday 05 January 2009 15:25, [email protected] wrote:
>> Author: j16sdiz
>> Date: 2009-01-05 15:25:07 +0000 (Mon, 05 Jan 2009)
>> New Revision: 24920
>>
>> Modified:
>>    trunk/freenet/src/freenet/clients/http/filter/ContentFilter.java
>> Log:
>> comment
>>
>> Modified: trunk/freenet/src/freenet/clients/http/filter/ContentFilter.java
>> ===================================================================
>> --- trunk/freenet/src/freenet/clients/http/filter/ContentFilter.java
> 2009-01-05 15:17:25 UTC (rev 24919)
>> +++ trunk/freenet/src/freenet/clients/http/filter/ContentFilter.java
> 2009-01-05 15:25:07 UTC (rev 24920)
>> @@ -118,11 +118,23 @@
>>                       this.type = type;
>>               }
>>       }
>> -
>> +
>>       /**
>>        * Filter some data.
>> -      * @param bf The bucket factory used to create the bucket to return the
> filtered data in.
>> -      * @throws IOException If an internal error involving buckets occurred.
>> +      *
>> +      * @param data
>> +      *            Input data
>> +      * @param bf
>> +      *            The bucket factory used to create the bucket to return 
>> the
> filtered data in.
>> +      * @param typeName
>> +      *            MIME type for input data
>> +      *
>> +      * @throws IOException
>> +      *             If an internal error involving buckets occurred.
>> +      * @throws UnsafeContentTypeException
>> +      *             If the MIME type is declared unsafe (e.g. pdf files)
>> +      * @throws IllegalStateException
>> +      *             If data is invalid (e.g. corrupted file) and the filter
> have no way to recover.
>
> IMHO IllegalStateException is not a good way to convey this, it should always
> be a FilterException...

CSS Tokenizer is doing this, I just document the current behavior.

>>        */
>>       public static FilterOutput filter(Bucket data, BucketFactory bf, String
> typeName, URI baseURI, FoundURICallback cb) throws
> UnsafeContentTypeException, IOException {
>>               if(Logger.shouldLog(Logger.MINOR, ContentFilter.class))
>
> _______________________________________________
> Devl mailing list
> [email protected]
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to