On Saturday 21 February 2009 14:29:11 Florent Daignière wrote: > * Matthew Toseland <[email protected]> [2009-02-21 14:15:50]: > > > On Saturday 21 February 2009 13:52:40 Florent Daignière wrote: > > > * Matthew Toseland <[email protected]> [2009-02-21 13:41:12]: > > > > > > > On Tuesday 27 January 2009 15:13:38 [email protected] wrote: > > > > > Author: nextgens > > > > > Date: 2009-01-27 15:13:37 +0000 (Tue, 27 Jan 2009) > > > > > New Revision: 25317 > > > > > > > > > > Modified: > > > > > trunk/freenet/src/freenet/node/NodeStats.java > > > > > Log: > > > > > cache the results for 60 secs > > > > > > > > IMHO this is over-optimisation. The only case in which we use this is > > > > rendering the statistics page in advanced mode. If the user wants detailed > > > > diagnostics, we should give them up to date and accurate figures. > > > > > > iirc that has a *significant* impact on "latency" of the whole node > > > because of locking contention... > > > > Only if they load the stats page more often than every 60 seconds? > > No, that's the point. > > Each time they click reload, the ImportantThreads were frozen for 2-3s trying to get access to their monitor.
Horrible... no idea how that would happen... > > I am not sure but I think I have addressed the root cause of it in an > other commit (refactoring the Ticker and its friends). Well, I'm not > sure I commited it in fact :) If you have a fix please commit it. :| > > NextGen$
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
