On Tue, Mar 3, 2009 at 4:10 AM, Florent Daignière
<[email protected]> wrote:
> * [email protected] <[email protected]> [2009-03-01 
> 07:25:01]:
>
>> Author: j16sdiz
>> Date: 2009-03-01 07:25:00 +0000 (Sun, 01 Mar 2009)
>> New Revision: 25866
>>
>> Modified:
>>    trunk/freenet/src/freenet/clients/http/filter/PNGFilter.java
>> Log:
>> Better error reporting on extra data in PNG file
>>
>> It was throwing java.io.EOFException error.
>> pngcheck reports "additional data after IEND chunk" for this kind of file
>>
>
> As far as I know the spec doesn't say that's allowed...
>
> Please revert this commit or prove me wrong.

This patch does not allow chunk after IEND.
The old code was throwing an EOFException.
This patch make it throw an IOException with the error message instead.

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEAREIAAYFAkmsPRoACgkQU/Z/dHFfxtcXegCeNkyKDnfhcFDNCnV8IaWCC3xN
> LTwAoOzQLSjS5DZlf5TzgJbD2QbPcDLq
> =Dflb
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Devl mailing list
> [email protected]
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to