On Friday 13 March 2009 04:02:22 [email protected] wrote: > Author: j16sdiz > Date: 2009-03-13 04:02:21 +0000 (Fri, 13 Mar 2009) > New Revision: 26013 > > Modified: > trunk/freenet/src/freenet/client/FetchException.java > Log: > Mark unused FetchException codes as deprecated > > Modified: trunk/freenet/src/freenet/client/FetchException.java > =================================================================== > --- trunk/freenet/src/freenet/client/FetchException.java 2009-03-12 > 21:30:48 UTC (rev 26012) > +++ trunk/freenet/src/freenet/client/FetchException.java 2009-03-13 > 04:02:21 UTC (rev 26013) > @@ -243,10 +243,13 @@ > // FIXME many of these are not used any more > > /** Too many levels of recursion into archives */ > + @Deprecated // not used > public static final int TOO_DEEP_ARCHIVE_RECURSION = 1; > /** Don't know what to do with splitfile */ > + @Deprecated // not used > public static final int UNKNOWN_SPLITFILE_METADATA = 2; > /** Too many redirects */ > + @Deprecated // not used > public static final int TOO_MANY_REDIRECTS = 16;
Why is this not used? Don't we detect circular references by a redirect count?
What error code do we use in that case?
> /** Don't know what to do with metadata */
> public static final int UNKNOWN_METADATA = 3;
> @@ -257,10 +260,12 @@
> /** Failed to decode a block */
> public static final int BLOCK_DECODE_ERROR = 6;
> /** Too many split metadata levels */
> + @Deprecated // not used
> public static final int TOO_MANY_METADATA_LEVELS = 7;
> /** Too many archive restarts */
> public static final int TOO_MANY_ARCHIVE_RESTARTS = 8;
> /** Too deep recursion */
> + // FIXME some TOO_MUCH_RECURSION may be TOO_DEEP_ARCHIVE_RECURSION
> public static final int TOO_MUCH_RECURSION = 9;
> /** Tried to access an archive file but not in an archive */
> public static final int NOT_IN_ARCHIVE = 10;
> @@ -308,6 +313,7 @@
> return isFatal(mode);
> }
>
> + @SuppressWarnings("deprecation")
> public static boolean isFatal(int mode) {
> switch(mode) {
> // Problems with the data as inserted, or the URI given. No
> point
retrying.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
