On Wednesday 08 April 2009 06:03:34 [email protected] wrote:
> Author: j16sdiz
> Date: 2009-04-08 05:03:33 +0000 (Wed, 08 Apr 2009)
> New Revision: 26635
> 
> Modified:
>    trunk/freenet/src/freenet/io/comm/UdpSocketHandler.java
> Log:
> Reduce SocketTimeOutException
> 
> SocketTimeOutException was causing the thread wake up
> every 1 second and creating (slow) Exceptions.
> 
> This patch, however, effectivly broke the Hang Checker,
> hence must be applied after the "Remove UDPSocket Hang
> Checker" patch.

As I understand it, waiting for a packet cannot be interrupted. Which means 
that after this patch is applied, shutting down opennet and then starting it 
up again within 2 minutes will break with a binding error. Correct?
> 
> Modified: trunk/freenet/src/freenet/io/comm/UdpSocketHandler.java
> ===================================================================
> --- trunk/freenet/src/freenet/io/comm/UdpSocketHandler.java   2009-04-08 
05:03:11 UTC (rev 26634)
> +++ trunk/freenet/src/freenet/io/comm/UdpSocketHandler.java   2009-04-08 
05:03:33 UTC (rev 26635)
> @@ -60,7 +60,6 @@
>               try {
>                       // Exit reasonably quickly
>                       _sock.setReuseAddress(true);
> -                     _sock.setSoTimeout(1000);
>               } catch (SocketException e) {
>                       throw new RuntimeException(e);
>               }

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to