On Tuesday 12 May 2009 14:16:54 Matthew Toseland wrote:
> commit c6f84c96d60a1e53126824e8c2fa74c1f1d4b658
> Author: platy <[email protected]>
> Date:   Sun May 3 13:52:16 2009 +0100
> 
>     Search progress now works with or without javascript enabled, non-js get 
a 
> link to view results when search completes
> 
> 
> Great! But...
> 
> Why all the while(blah) { Thread.sleep() } 's ? Wouldn't wait/notify be 
> better?
> 
> What is the purpose of the hidden Find! button?
> 
> commit 3a9754b92ea88bfe99019af8810f96d537ff3a79
> Author: platy <[email protected]>
> Date:   Tue May 5 03:43:39 2009 +0100
> 
>     Removed use of JS & Iframes entirely
> 
> Why? Isn't javascript useful to refresh only part of the page, avoid the 
> clunky feeling of reloading frequently? Clearly refresh is better for 
> non-javascript... It does work pretty well now though, thanks!
> 
> We should include the searched-for term in the title of the page.

I have made some changes:
- Refactored handleInner() a bit.
- Fixed a bug causing infinite looping continually fetching and re-fetching 
the same index (for me it happens when i search for antarctica).
- Fixed the Searching for blah\nnull bug.

The plugin will be deployed soon.

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to