On Fri, Jul 3, 2009 at 2:01 AM, Matthew Toseland<[email protected]> wrote: > On Friday 03 July 2009 01:00:00 Matthew Toseland wrote: >> 1794de9ad5df4b2cdb3bbb8f0a89c3e4da6e3175 : >> >> + private int getTime(){ >> + return (int)(System.currentTimeMillis()); >> + } >> + >> >> - you will get wrap-around problems when checking the keepalive in >> followerTakeOverTimer, no?? >>
It is a bug, but actually it doesn't do any wrong. I've corrected it anyway. Because javascript has no variable types, it ignores castings. Because of this, it worked well. >> >> logToWindow >> - unsafe due to not encoding; not a problem if no end user ever runs this, >> but should document? >> fixed, escaping ". HTML tags doesn't need escaping here, GWT does this automatically. >> >> testing: >> imho requests stall, both mid-way and at 100%. >> requests definitely stall at 100% - stuck on 100% for minutes, reload >> manually and it immediately shows content type warning. >> definitely stall below that too, doing same trick shows much progress. >> > This might explain some of the problems: > > Jul 02, 2009 23:58:36:359 (java.lang.Class, HTTP socket > hand...@763900730(47), ERROR): Caught error: java.lang.NullPointerException > handling socket > java.lang.NullPointerException > at > freenet.clients.http.updateableelements.PushDataManager.getNextNotification(PushDataManager.java:166) > at > freenet.clients.http.PushNotificationToadlet.handleGet(PushNotificationToadlet.java:24) > at > freenet.clients.http.ToadletContextImpl.handle(ToadletContextImpl.java:372) > at > freenet.clients.http.SimpleToadletServer$SocketHandler.run(SimpleToadletServer.java:694) > at freenet.support.PooledExecutor$MyThread.run(PooledExecutor.java:224) > It is now should be fixed. Found some horrible bugs that caused stalling, and fixed them. I'm testing it for some time, and haven't experienced any stops yet. Please mail me if you experience it further. sashee _______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
