On Sun, Nov 22, 2009 at 7:13 AM, Matthew Toseland
<[email protected]> wrote:
> Is it always non-null *in all derived classes*?
/metas/ is a *local* variable, and it is set to /null/ just one line
before the /if/:
line 1568: ArrayList<Metadata> metas = null;
line 1569: if(metas != null) {
>
> diff --git a/src/freenet/client/async/BaseManifestPutter.java
> b/src/freenet/client/async/BaseManifestPutter.java
> index 2bad947..80b9eb1 100644
> --- a/src/freenet/client/async/BaseManifestPutter.java
> +++ b/src/freenet/client/async/BaseManifestPutter.java
> @@ -1566,13 +1566,6 @@ public abstract class BaseManifestPutter extends
> BaseClientPutter {
> container.activate(ctx, 1);
> ctx.removeFrom(container);
> ArrayList<Metadata> metas = null;
> - if(metas != null) {
> - for(Metadata meta : metas) {
> - if(meta == baseMetadata) continue;
> - container.activate(meta, 1);
> - meta.removeFrom(container);
> - }
> - }
> if(baseMetadata != null) {
> container.activate(baseMetadata, 1);
> baseMetadata.removeFrom(container);
>
>
_______________________________________________
Devl mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
