On 05/09/14 18:34, Matthew Toseland wrote: > It looks like somebody messed up and removed a close() which was before > a rename, probably in BaseFileBucket. Such a bug could break Windows > nodes very badly, so please be very careful reviewing the change before > deploying. > > [18:11:18] <TheSeeker> toad_: looks like the plugin data saving bit is > not finishing the temp file rename (trying to rename while open?) > [18:11:28] <toad_> TheSeeker: ouch > [18:11:32] <toad_> TheSeeker: not a regression mind you > [18:11:34] <TheSeeker> I have files like: > plugins.floghelper.FlogHelper.data1029365099476005573.freenet-tmp in my > plugin-data dir. > [18:11:36] <toad_> TheSeeker: always happens on Windows? > [18:11:44] <TheSeeker> that didn't used to happen :P > [18:11:53] <toad_> TheSeeker: hmmm ... it could have broken sometime? > [18:12:18] <TheSeeker> sometime during purge-db4o yes. > [18:12:33] <toad_> TheSeeker: I haven't done anything to that code :| > [18:12:37] <toad_> TheSeeker: is this Windows? > [18:15:20] <TheSeeker> toad_: yes, windows. likely something to do with > a change I saw somewhere assuming that java will always close things > properly? (so maybe on next, not purge-db4o?) > [18:15:38] <toad_> TheSeeker: yeah that might be it ... are you running > java 7? > [18:15:42] <TheSeeker> 8 > [18:15:48] <toad_> so it should work then? :| > [18:16:04] <toad_> if you can show it doesn't work then something needs > to be done about it urgently as it may break windows nodes badly > [18:20:08] <TheSeeker> gah! I don't understand why files are being > created with e.g. 1029365099476005573.freenet-tmp at the end... that > doesn't look like what ClientPersister is supposed to be doing... > [18:20:18] <toad_> TheSeeker: that's a temp file > [18:20:25] <toad_> FileBucket does it > [18:20:31] <toad_> but when it closes it should rename it over the target > [18:20:42] <toad_> if it can't rename it over the target then something > is SERIOUSLY wrong > [18:20:57] <toad_> if it's that badly wrong there's a good chance of > breaking every single Windows node when operhiem1 eventually deploys the > update > [18:21:18] <toad_> but I don't understand it since java is supposed to > guarantee that it it closed when you exit the braces :( > [18:21:26] <toad_> probably somebody messed up and didn't close quite > early enough > [18:32:53] <toad_> TheSeeker: do you see any problems with other areas? > [18:33:09] <toad_> TheSeeker: most likely it's a typo, somebody deleted > a close() at the wrong place? > [18:33:35] <toad_> TheSeeker: somebody needs to carefully review those > changes ... but not me. it's not my problem, i haven't finished my main > task yet. This was not caused by the Java 7 changes. It was a Windows-specific bug in purge-db4o. It is fixed now.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
