On 02.11.2014, at 01:50, Steve Dougherty <st...@asksteved.com> wrote:

> While I can understand the thought behind not wanting to touch all the
> code at once, I think it makes a transition messy and interminable.

Unfortunately, that is true. :/


> I would be up for, after pull requests that should be merged are merged,
> automatically formatting the codebase to meet Google's Java style guide
> with as much as it can without changing the bytecode.

I think there are quite some changes that can not be done automatically, such 
as grouping/ordering methods and fields, or adding comments for those empty 
catch blocks. Then there is also the issue of javadoc, which is missing in ~99% 
of the places it’s supposed to be. No tool can do that automatically, and for a 
single person to add all those is pretty much impossible; after all we are 
talking about ~1000 source files.

I do understand the motivation behind getting it done as quickly as possible 
(and that sure is tempting) but I don’t think the result would be code that 
conforms to this particular style guide.


Greetings,
-- 
 * David ‘Bombe’ Roden <bo...@pterodactylus.net>

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
Devl mailing list
Devl@freenetproject.org
https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to