On 15/11/14 09:21, xor wrote: > Hey toad, > > as Steve has already tagged a pre-release for the build which will deploy > purge-db4o, I am trying to fix WOT to compile against it. > > I am not sure what to replace this function from the pre-purge-db4o code with: > https://github.com/freenet/fred/blob/build01466/src/freenet/client/HighLevelSimpleClient.java#L96 > > Naively, I could say "RequestClient is a 'foreign thing' as it does not > specify any information relevant to WOT, so I just use the function which has > that parameter removed since only fred cared about it" and use this one: > https://github.com/freenet/fred/blob/6596c3e238340ce19a34f9e32611862c8f2a4390/src/freenet/client/HighLevelSimpleClient.java#L96 Yes, this is correct. > But isn't the RequestClient very important for fred? I think it is used to > ensure that traffic is round-robined between whole clients instead of on the > individual request level - which is critical to prevent that clients which do > very many requests such as WOT do not starve other stuff? The new Client[Get]Callback API has a method to return a RequestClient. > So how am I supposed to replace that function? > WOT actually uses *all* of the other parameters in a non-default manner, i.e. > to specify stuff, so the only other function which allows specification of a > RequestClient IMHO is not an option > (that being "public FetchResult fetch(FreenetURI uri, long maxSize, > RequestClient context) throws FetchException;" - notice how it especially > does > not allow specification of a callback object, so its a blocking fetch I > guess, > and thus would require complete changing of the architecture of the existing > code in WOT which is event-driven instead of a thread which calls blocking > functions.) > > Greetings and thanks, > xor
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
