On Nov 21, 2014 11:01 AM, "Juiceman" <juicema...@gmail.com> wrote: > On Nov 21, 2014 10:19 AM, "Matthew Toseland" <mj...@cam.ac.uk> wrote: > > On 21/11/14 09:52, Steve Dougherty wrote: > > > Bug #6411 [0] got into build 1466. > > > > > > When Fred writes the configuration file on startup > > > `pluginmanager.loadplugins` is blank due to a race condition introduced > > > by 869f62559a06b2f72c9224a2179001dd551ea442. If, after all plugins have > > > started or failed to start, a configuration change or clean shutdown > > > causes the configuration to be written again it will be written > > > correctly. This means a crash will likely clear the node's list of > > > plugins to load. > > Do we need to reset to the default list of plugins to work around this? > > E.g. UPnP/STUN can be really essential in some cases ... but some people > > really want to turn them off. Thoughts?
Silently enabling plugins seems annoying / bad, especially for something that may be rare, and implementing either just that or something to prompt the user for what to do would be expensive; see below. Also, the signature on toad_'s message fails verification for me as well as xor. (I suspect the mailing list adding its footer did that?) > Put up a user alert that warns users to check their plugins and re-add > UPnP/STUN etc if missing. Users that don't want them can ignore it. I don't want to do that: implementing, translating, and testing it will push release back until next weekend at the absolute minimum. It's a lot of effort for a one-off thing, delay gives more time for users to be hit by the bug, and anyone already unable to connect due to it will not get the update automatically anyway. What makes sense to me is posting what to do if hit by the bug in various places. Something like: "If you are affected by this bug and can no longer connect, try adding the UPnP or JSTUN plugins again." It's worth noting that if the external IP cannot be detected there is already an alert which among other things suggests adding UPnP/JSTUN. (IPUndetectedUserAlert) > Can alerts be set as permanent until dismissed and then not show again > again, even if node is rebooted? Certainly, for instance by adding a configuration option for whether the alert has been dismissed.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
