Hi,
(Is there a better place to report bugs?)

the two forms that report failed Get requests in fproxy and allow
users to retry (with possibly another HTL) include the url-encoded key
in their ACTION attribute. Unfortunately java.net.URLEncoder encodes
"/" which is wrong at least in this context[1].

The retries will go to URLs that look like

  http://localhost:8888/SSK%40...%2ffrancophonie%2f%2f?htl=17

These fetch fine, but browsers will not be able to resolve relative
links: Since there is no slash present in the key part of the URL, a
relative link to "foo.html" will go to

  http://localhost:8888/foo.html

That means that most intra-site links and images will be broken.

The attached patch attempts to fix this with an encoding function that
encodes like URLEncoder except that "/" is left alone. This function
throws when encountering a character with numeric value outside
[0,255]. Note that URLEncoder also behaves badly with these kind of
characters.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 2223 bytes
Desc: not available
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20011214/dfa812a1/attachment.bin>
-------------- next part --------------


Footnotes: 
[1]  And maybe in general, see RFC1738 for details.

-- 
Robbe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.ng
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20011214/dfa812a1/attachment.pgp>

Reply via email to