Dang, you know, I wish I had email access at my desk at work, I'd be able to do my fixes in a more timely fashion.
The following bugs have very recently come to light, thanks to the very great work of David McNab and Reudiger Kapitza and Zhang Delong on the support mailing list: 1. Freenet doesn't like having spaces in the pathnames in flaunch.ini 2. Freenet doesn't like the Sunsoft version of javaw.exe 3. Memory corruption / compiler optimisation problem with freenet.exe and/or config.dll (only observed with latest config.dll and recent-ish freenet.exe variants but this is not (yet) evidence that the problem lies in config.dll) 4. Presence of config.dll is making non-reentrant WndProc code run multiple times from multiple threads leading to occasional weirdness. With the latest 0.3.9.1-2 this is causing the following symptoms: 1. Freenet.exe doesn't play fairly when presented with a filename that contains spaces - probably my bad :-(( I have never noticed this during testing since my flaunch.ini is set to use the java.exe in G:\Winnt\System32\java.exe - I have received similar reports from other people and the spaces-in-filename-bug is the cause. 2. Javaw.exe doesn't comply with the "WaitForInputIdle" API call - this results in the "load the node" thread of freenet.exe hanging, waiting for an event from javaw.exe which (as far as I can tell) never occurs. 3. Freenet.exe says "freenet is stopped" but in fact the "load the node" thread of freenet.exe is hung and so requests to "Start Freenet" are helpfully ignored. However Freenet is in fact running. Way to stop the freenet node at this point is unfortunately to kill the javaw.exe using Task Manager. 4. Memory corruption / compiler optimisation problem with freenet.exe and/or config.dll is causing memory allocation / deallocation problems and/or stack corruption when config.dll closes and this causes freenet.exe to blow itself away. 5. Had everything been setup and configured ok (:-) it would be possible to load multiple copies of the configurator at a time - this is unintuitive and very bad for first-timers. I am currently checking in fixes into CVS. I will announce when they are ready: 1. Freenet.exe will from this release *only look at javaexec entry* in flaunch.ini and *ignore javaw entry*. This is safest (I wasn't previously aware of this problem with Sun's javaw.exe application) 2. Spaces in javaexec entry will be coped with (like I said, my bad (( - I'm pretty sure it used to work ok, I'm sorry folks) 3. WaitForInputIdle call removed from code. No side effects anticipated although a potential (harmless) race condition is a possibility should you try to start and then immediately stop the freenet node. In practice the user interface prevents this from happening. 4. From this release *neither freenet.exe nor config.dll will be compiled with any compiler optimisations*. Until the memory corruption (caused by compiler settings) problem is fully investigate this seems the total best and safest way forward. 5. Section locking now added to freenet.exe to prevent multiple copies of configurator in config.dll being loaded. I can't honestly work out WHY this is happening - the code in question (the message pump in freenet.exe) is single threaded so how it is running from multiple threads is a mystery. Will need to work with Sebastian to get to the bottom of it. However this fix works. Also the following cosmetic change: 1. The "Open Gateway Page" menu option on the right-click-popup menu is now emboldened to comply with current Windows user interface guidelines. This is because it is the "default option" (the gateway page is opened when you double-click the icon) ****Sebastian, the following actions are with you:**** 1. Rebuild config.dll to use no compiler optimisations ( as you know from our conversations, we cannot deny the possibility of a compiler bug here ). Experimental evidence with freenet.exe indicates less than 512bytes of difference and you are likely to find similar results with config.dll 2. Consider whether or not to make the installer automatically put quotes around pathnames that contain spaces (this is entirely up to you, as the workaround will be in freenet.exe anyway). Let me know what you think (although whatever you do don't do it yet for this release!) 3. Fix findjava.exe problem as reported by David McNab Thanks people. For small values of N, N+1 heads are better than N. Dave ----- Original Message ----- From: "David McNab" <da...@rebirthing.co.nz> To: <devl at freenetproject.org> Sent: Wednesday, May 30, 2001 12:23 PM Subject: [freenet-devl] Freenet Winstaller - 0.3.9.1-2 TEST RESULTS > > I just put together the new installer fresh from CVS. It is at > > http://prdownloads.sourceforge.net/freenet/Freenet_setup0.3.9.1-2.exe > > Test report - Freenet Winstaller 0.3.9.1-2 > > Summary: FAILED > [snip - you know the rest] _______________________________________________ Devl mailing list Devl at freenetproject.org http://lists.freenetproject.org/mailman/listinfo/devl
