On Monday 11 August 2008 17:26, Daniel Cheng wrote: > On Mon, Aug 11, 2008 at 11:54 PM, Florent Daigni?re > <nextgens at freenetproject.org> wrote: > > * Daniel Cheng <j16sdiz+freenet at gmail.com> [2008-08-11 23:07:43]: > > > >> On Mon, Aug 11, 2008 at 10:39 PM, <nextgens at freenetproject.org> wrote: > >> > Author: nextgens > >> > Date: 2008-08-11 14:39:46 +0000 (Mon, 11 Aug 2008) > >> > New Revision: 21748 > >> > > >> > Modified: > >> > trunk/freenet/src/freenet/clients/http/FirstTimeWizardToadlet.java > >> > trunk/freenet/src/freenet/node/NodeIPDetector.java > >> > trunk/freenet/src/freenet/pluginmanager/PluginInfoWrapper.java > >> > trunk/freenet/src/freenet/pluginmanager/PluginManager.java > >> > Log: > >> > Skip the bandwidth limiting step in the wizard if the node has detected a recent enough, and working UPnP plugin > >> > > >> > >> My router never give the correct bandwidth via UPnP interface. > >> It's better to just select the detected bandwidth as default, not > >> skipping the step. > >> > > > > Heh, I didn't want to implement that up&p crap... but toad pushed > > hard on me to do so... and so far the answer has always been: assume that > > it works as expected; even if it works in 5% of the cases that's good > > enough to be worth implementing. > > > > Out of curiosity, what does it report? (you can see it if you visit the > > plugin's page via fproxy). The spec says that if not implemented it > > should return a negative value. > > > > It was returning the correct value.. > Sorry for noise.
IMHO we should present the step anyway. Many users will want to tweak it e.g. because of traffic limits, other apps, etc. Most users will just click next, which is also fine. > > > NextGen$ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080811/389d04ec/attachment.pgp>
