nextgens commented on SVN revision 21841. Details are at http://code.google.com/p/freenet/source/detail?r=21841
Score: Negative General Comment: I'm trying out the code review tool Line-by-line comments: File: /trunk/freenet/src/freenet/node/Node.java (r21841) =============================================================================== Line 187: cachedStoreType = val; ------------------------------------------------------------------------------- You should check whether "val" contains a PossibleValue here... and throw an InvalidConfigException otherwise! Line 200: return false; ------------------------------------------------------------------------------- what about removing the method altogether? Respond to these comments at http://code.google.com/p/freenet/source/detail?r=21841 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings
