Matthew Toseland skrev: >> On top of my head: >> - Cleaner code >> - Proper detection of FireFox location >> > > We don't already have that? We check the registry etc ... >
Atm. we check for FF in "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App Paths\firefox.exe" (Used for various things like the "Run" dialog and loading common .dlls without knowing the full path) instead of the official "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\3.0.4 (da)\Main\PathToExe" (On my system, version and locale string is fetched from "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\CurrentVersion"). It's not really wrong as we do it now, but we really should check the official key and eventually fall back to App Path (or path to http protocol handler application, or default install dir). > >> - profiles.ini watchdog thingy >> > > I had figured we'd implement this in java and start it when launching the > browser. Then we solve it for non-Windows as well. Our last report was on > Debian. > > Sure thing! I simply figured nobody had the time so I thought I might as well do what I could. >> - Check if node is running before launching FF (and if not, start or >> inform user in a GUI message box) (and if needed, shutdown node >> afterwards as well) >> > > Not possible, as we've discussed. > It is not? We should be able to check if a system service is running even as a low-access user, and if not, at least warn about it (instead of failing miserably with a "server not found" error in FF). I Googled around a bit, and it appears that it is actually possible to give low-access users access to start and stop a specific service: http://www.eventlogblog.com/blog/2007/11/setting-service-permissions-wi.html We most likely cannot comply with the EULA though: "1. GRANT OF LICENSE. Provided that you comply with all terms and conditions of this EULA, Microsoft grants you a personal, nonexclusive, royalty-free license to install and use the Software. You may install and use the Software on an unlimited number of computers so long as you are the only individual or entity using the Software." So unless we want to manually hack the access hex array "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\<service name>\Security\Security" or can find a free tool to do it, we'll have to just warn non-admin users. > >> - If wanted, GUI warnings about missing daemon, FF or FF profile (we >> talked a bit about the possibility of nagging users without daemon enabled) >> > > As opposed to just creating it if it doesn't exist? Okay, telling the user to > get FF would be useful. > Or that, yes. > >> Main reason for doing a real launcher (in AHK) was that doing the >> profile.ini fix in a .cmd file would most likely turn up to be quite >> ugly, so instead of having both a watchdog and a launcher, I figure you >> might as well combine them. >> > > True. But doing it in java is easy, and the JVM code will mostly be shared > anyway so it won't be a high overhead. And it will be more maintainable. > As before, that sounds cool with me. But as my situation is right now, I simply do not have the time or motivation to sit down and learn a new launguage :). So I'll leave it to someone else for now, then. - Zero3
