On Thursday 18 December 2008 13:18, Zero3 wrote: > Matthew Toseland skrev: > >> On top of my head: > >> - Cleaner code > >> - Proper detection of FireFox location > >> > > > > We don't already have that? We check the registry etc ... > > > > Atm. we check for FF in > "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App > Paths\firefox.exe" (Used for various things like the "Run" dialog and > loading common .dlls without knowing the full path) instead of the > official "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\3.0.4 > (da)\Main\PathToExe" (On my system, version and locale string is fetched > from "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla > Firefox\CurrentVersion"). It's not really wrong as we do it now, but we > really should check the official key and eventually fall back to App > Path (or path to http protocol handler application, or default install dir).
That's easy enough to fix within browse.cmd. Although checking specific version numbers really sucks - CurrentVersion is obviously better. You want to just do it or file a bug? > > >> - profiles.ini watchdog thingy > > > > I had figured we'd implement this in java and start it when launching the > > browser. Then we solve it for non-Windows as well. Our last report was on > > Debian. > > Sure thing! I simply figured nobody had the time so I thought I might as > well do what I could. This is true, sadly. But we do need a fix for non-Windows too. And if it's written in java it's easier to maintain. > > >> - Check if node is running before launching FF (and if not, start or > >> inform user in a GUI message box) (and if needed, shutdown node > >> afterwards as well) > > > > Not possible, as we've discussed. > > It is not? We should be able to check if a system service is running > even as a low-access user, and if not, at least warn about it (instead > of failing miserably with a "server not found" error in FF). Granted we could warn the user yes. > > I Googled around a bit, and it appears that it is actually possible to > give low-access users access to start and stop a specific service: > http://www.eventlogblog.com/blog/2007/11/setting-service-permissions-wi.html Nice... > > We most likely cannot comply with the EULA though: > > "1. GRANT OF LICENSE. Provided that you comply with all terms and > conditions of this EULA, Microsoft grants you a personal, nonexclusive, > royalty-free license to install and use the Software. You may install > and use the Software on an unlimited number of computers so long as you > are the only individual or entity using the Software." Hmmm, curious, given the multi-user UI optimisations in Windows XP ... > > So unless we want to manually hack the access hex array > "HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\<service > name>\Security\Security" or can find a free tool to do it, we'll have to > just warn non-admin users. I don't see why the license prohibiting multiple users when the UI blatantly encourages it is our problem. We should just hack the registry. That will avoid permissions problems, although obviously the update scripts would still have permissions problems ... but maybe there is a way to avoid them there too?? > > >> - If wanted, GUI warnings about missing daemon, FF or FF profile (we > >> talked a bit about the possibility of nagging users without daemon enabled) > > > > As opposed to just creating it if it doesn't exist? Okay, telling the user to > > get FF would be useful. > > Or that, yes. > > >> Main reason for doing a real launcher (in AHK) was that doing the > >> profile.ini fix in a .cmd file would most likely turn up to be quite > >> ugly, so instead of having both a watchdog and a launcher, I figure you > >> might as well combine them. > > > > True. But doing it in java is easy, and the JVM code will mostly be shared > > anyway so it won't be a high overhead. And it will be more maintainable. > > As before, that sounds cool with me. But as my situation is right now, I > simply do not have the time or motivation to sit down and learn a new > launguage :). So I'll leave it to someone else for now, then. If you're going to build a launcher anyway then include the profile fix. > > - Zero3 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20081218/3f78dc6e/attachment.pgp>
