Ian: example of why we need DVCS IMHO. I committed a patch from ET on Frost, because I want anonymous contributors, and to encourage a new dev. I did a basic code review (and gave input on architecture, this is the second patch to be committed), now nextgens is quibbling about it...
On Tuesday 25 December 2007 01:19, Florent Daigni?re wrote: > * toad at freenetproject.org <toad at freenetproject.org> [2007-12-22 > 00:12:28]: > > > Author: toad > > Date: 2007-12-22 00:12:28 +0000 (Sat, 22 Dec 2007) > > New Revision: 16775 > > > > Added: > > trunk/freenet/src/freenet/crypt/SSL.java > > trunk/freenet/src/freenet/io/SSLNetworkInterface.java > > Modified: > > trunk/freenet/src/freenet/clients/http/SimpleToadletServer.java > > trunk/freenet/src/freenet/l10n/freenet.l10n.en.properties > > trunk/freenet/src/freenet/node/NodeStarter.java > > trunk/freenet/src/freenet/node/TextModeClientInterfaceServer.java > > trunk/freenet/src/freenet/node/fcp/FCPServer.java > > Log: > > Patch from ET at mj+bSV4hxRMtCj9fcwy4Ww9_3mc on Frost: Add SSL support for FCP, HTTP, TMCI. > > Request testing! > > > > Why has it been commited and released ? > 1) it depends on sun.security.x509.X500Name Which is bad because...? > 2) errors sent back by the config. framework aren't > internationalized AFAIK this is a problem in many places in Fred. > 3) they are obvious typos and french comments! Okay, French comments are bad. I did read it before I committed it, it seemed okay, but maybe I was asleep at that point. > > Don't get me wrong: contributions are welcome... but they should meet a > given quality standard to get merged and deployed. How do you propose we discuss such contributions? Did you see it on Frost? Our current protocol is to throw everything into trunk, 99% of the time. Maybe it should have gone into a branch, but IMHO the ideal is a DVCS so I can just post the (freenet-based) url on devl. I don't suppose you'd be interested in getting that working? > > NextGen$ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080102/b3dca549/attachment.pgp>
