* Matthew Toseland <toad at amphibian.dyndns.org> [2008-01-02 12:56:11]:
> On Tuesday 25 December 2007 01:19, Florent Daigni?re wrote:
> > * toad at freenetproject.org <toad at freenetproject.org> [2007-12-22
> > 00:12:28]:
> >
> > > Author: toad
> > > Date: 2007-12-22 00:12:28 +0000 (Sat, 22 Dec 2007)
> > > New Revision: 16775
> > >
> > > Added:
> > > trunk/freenet/src/freenet/crypt/SSL.java
> > > trunk/freenet/src/freenet/io/SSLNetworkInterface.java
> > > Modified:
> > > trunk/freenet/src/freenet/clients/http/SimpleToadletServer.java
> > > trunk/freenet/src/freenet/l10n/freenet.l10n.en.properties
> > > trunk/freenet/src/freenet/node/NodeStarter.java
> > > trunk/freenet/src/freenet/node/TextModeClientInterfaceServer.java
> > > trunk/freenet/src/freenet/node/fcp/FCPServer.java
> > > Log:
> > > Patch from ET at mj+bSV4hxRMtCj9fcwy4Ww9_3mc on Frost: Add SSL support
> > > for
> FCP, HTTP, TMCI.
> > > Request testing!
> > >
> >
> > Why has it been commited and released ?
> > 1) it depends on sun.security.x509.X500Name
>
> Which is bad because...?
It breaks freejvm support (freenet is reported to be working on recent
gij)
>
> > 2) errors sent back by the config. framework aren't
> > internationalized
>
> AFAIK this is a problem in many places in Fred.
True but introducing more is definitely not going to help ;)
>
> > 3) they are obvious typos and french comments!
>
> Okay, French comments are bad. I did read it before I committed it, it seemed
> okay, but maybe I was asleep at that point.
> >
> > Don't get me wrong: contributions are welcome... but they should meet a
> > given quality standard to get merged and deployed.
>
> How do you propose we discuss such contributions?
Well, it's clear that we aren't ready to deal with "big" anonymous
contributions... but so far it hasn't been a worry because we don't have
many anon. contributors... and most of the time they publish trivial
patches.
>Did you see it on Frost?
Yes, and there too I was the first one to criticize it
> Our current protocol is to throw everything into trunk, 99% of the time.
> Maybe it
> should have gone into a branch,
I think it would have been better for it to remain in a branch, yes.
I have no problem with such patches being in our trunk... but you shouldn't
release right after they have been introduced.
> but IMHO the ideal is a DVCS so I can just
> post the (freenet-based) url on devl. I don't suppose you'd be interested in
> getting that working?
I have no time to do it atm... but will have a look after I've passed my
exams.
I'm reluctant to use a DSCM in our case for a few reasons:
1) they are more difficult to use: that will be one additional
fence each of our contributors will have to pass before he can
start to contribute
2) they are "young": more likely to be prone to bugs and stuffs
like that (keep in mind that we did experience data corruption
with svn... which is believed to be robust!)
3) last time I checked they weren't any "good" GUIs: you are the
one who told me "as long as there is an eclipse integration I
don't mind what we are using" back when I made you switch from
CVS to SVN ;)
If you're still convinced that it's the way to go, I'll have a closer
look to what's doable... We did talk about it at the gSoC mentor summit
and because of my point (1) we ended up concluding "maybe latter".
NextGen$
PS: a point I forgot to state in my previous email : from an architectural
point of view, I don't think that we should have "one" fproxy but more...
One with and one without ssl support, possibly running on different port
numbers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080102/fe3274d2/attachment.pgp>
