On Wednesday 08 April 2009 12:55:15 Florent Daigniere wrote:
> j16sdiz at freenetproject.org wrote:
> > Author: j16sdiz
> > Date: 2009-04-07 15:04:51 +0000 (Tue, 07 Apr 2009)
> > New Revision: 26603
> > 
> > Modified:
> >    trunk/freenet/src/freenet/crypt/Yarrow.java
> > Log:
> > Just clear the hashtable
> > 
> > We are in synchronized{}, this have to be very fast
> > 
> > Modified: trunk/freenet/src/freenet/crypt/Yarrow.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/crypt/Yarrow.java     2009-04-07 15:04:29 UTC 
(rev 26602)
> > +++ trunk/freenet/src/freenet/crypt/Yarrow.java     2009-04-07 15:04:51 UTC 
(rev 26603)
> > @@ -660,9 +660,7 @@
> >             fast_pool_reseed();
> >             slow_entropy = 0;
> >  
> > -           Integer ZERO = 0;
> > -           for(EntropySource src : entropySeen.keySet())
> > -                   entropySeen.put(src, ZERO);
> > +           entropySeen.clear();
> >     }
> >     /**
> >      * 5.4 Reseed Control parameters
> > 
> 
> It doesn't do the same thing! We want the memory to be overwritten here, no?

No, I don't think it's an issue, look at the other places where we access 
entropySeen.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20090408/d4a67560/attachment.pgp>

Reply via email to