On Wed, Apr 8, 2009 at 7:55 PM, Florent Daigniere
<nextgens at freenetproject.org> wrote:
> j16sdiz at freenetproject.org wrote:
>> Author: j16sdiz
>> Date: 2009-04-07 15:04:51 +0000 (Tue, 07 Apr 2009)
>> New Revision: 26603
>>
>> Modified:
>> ? ?trunk/freenet/src/freenet/crypt/Yarrow.java
>> Log:
>> Just clear the hashtable
>>
>> We are in synchronized{}, this have to be very fast
>>
>> Modified: trunk/freenet/src/freenet/crypt/Yarrow.java
>> ===================================================================
>> --- trunk/freenet/src/freenet/crypt/Yarrow.java ? ? ? 2009-04-07 15:04:29
>> UTC (rev 26602)
>> +++ trunk/freenet/src/freenet/crypt/Yarrow.java ? ? ? 2009-04-07 15:04:51
>> UTC (rev 26603)
>> @@ -660,9 +660,7 @@
>> ? ? ? ? ? ? ? fast_pool_reseed();
>> ? ? ? ? ? ? ? slow_entropy = 0;
>>
>> - ? ? ? ? ? ? Integer ZERO = 0;
>> - ? ? ? ? ? ? for(EntropySource src : entropySeen.keySet())
>> - ? ? ? ? ? ? ? ? ? ? entropySeen.put(src, ZERO);
>> + ? ? ? ? ? ? entropySeen.clear();
>> ? ? ? }
>> ? ? ? /**
>> ? ? ? ?* 5.4 Reseed Control parameters
>>
>
> It doesn't do the same thing! We want the memory to be overwritten here, no?
It just a counter for number of bits available -- no secrets here.
(and putting zero in a map does not clean it more then calling .clear())
