On Thu, Apr 30, 2009 at 9:37 PM, Matthew Toseland <toad at amphibian.dyndns.org> wrote: > On Thursday 30 April 2009 01:50:27 Daniel Cheng wrote: >> On Thu, Apr 30, 2009 at 8:37 AM, Matthew Toseland >> <toad at amphibian.dyndns.org> wrote: >> > On Thursday 30 April 2009 01:03:58 Daniel Cheng wrote: >> >> On Thu, Apr 30, 2009 at 8:02 AM, Matthew Toseland >> >> <toad at amphibian.dyndns.org> wrote: >> >> > On Thursday 23 April 2009 02:40:26 j16sdiz at freenetproject.org wrote: >> >> >> Author: j16sdiz >> >> >> Date: 2009-04-23 01:40:25 +0000 (Thu, 23 Apr 2009) >> >> >> New Revision: 27218 >> >> >> >> >> >> Modified: >> >> >> ? ?trunk/contrib/fec/src/com/onionnetworks/fec/Native16Code.java >> >> >> ? ?trunk/contrib/fec/src/com/onionnetworks/fec/Native8Code.java >> >> >> ? ?trunk/contrib/fec/src/csrc/com_onionnetworks_fec_Native16Code.h >> >> >> ? ?trunk/contrib/fec/src/csrc/com_onionnetworks_fec_Native8Code.h >> >> >> ? ?trunk/contrib/fec/src/csrc/fec16-jinterf.c >> >> >> ? ?trunk/contrib/fec/src/csrc/fec8-jinterf.c >> >> >> Log: >> >> >> Use GetLongField() / SetLongField() >> >> >> >> >> > ... >> >> >> Modified: trunk/contrib/fec/src/csrc/fec8-jinterf.c >> >> >> =================================================================== >> >> >> --- trunk/contrib/fec/src/csrc/fec8-jinterf.c 2009-04-23 01:40:07 UTC >> > (rev >> >> > 27217) >> >> >> +++ trunk/contrib/fec/src/csrc/fec8-jinterf.c 2009-04-23 01:40:25 UTC >> > (rev >> >> > 27218) >> >> > ... >> >> >> >> >> >> -/* >> >> >> - * The data[] MUST be preshuffled before this call is made or it WILL >> > NOT >> >> >> - * WORK! ?It is very difficult to make Java aware that the pointers > have >> >> >> - * been shuffled in the encode() call, so we must pre-shuffle the > data >> >> >> - * so that encode doesn't move any pointers around. >> >> >> - */ >> >> > >> >> > Why delete this comment? And the one in fec16-jinterf too? >> >> >> >> No specific reason. >> >> I was syncing fec8-jinterf.c and fec16-jinterf.c so they look identical >> >> in layout and comments. >> > >> > Both of them had that comment. Would you mind reinstating it? >> > >> >> I don't have write access to contrib :) > > You do now. >
Thanks, Fixed at 647b85b906d13c01d60cb17fb149678a1d47032a
