On Monday 05 January 2009 17:58, Zero3 wrote: > Matthew Toseland skrev: > > On Friday 02 January 2009 16:50, Zero3 wrote: > > > >> Matthew Toseland skrev: > >> > >>> On Thursday 18 December 2008 13:18, Zero3 wrote: > >>> > >>> > >>>> Matthew Toseland skrev: > >>>> > >>>> > >>>>>> On top of my head: > >>>>>> - Cleaner code > >>>>>> - Proper detection of FireFox location > >>>>>> > >>>>>> > >>>>>> > >>>>> We don't already have that? We check the registry etc ... > >>>>> > >>>>> > >>>>> > >>>> Atm. we check for FF in > >>>> "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App > >>>> Paths\firefox.exe" (Used for various things like the "Run" dialog and > >>>> loading common .dlls without knowing the full path) instead of the > >>>> official "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\3.0.4 > >>>> (da)\Main\PathToExe" (On my system, version and locale string is fetched > >>>> from "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla > >>>> Firefox\CurrentVersion"). It's not really wrong as we do it now, but we > >>>> really should check the official key and eventually fall back to App > >>>> Path (or path to http protocol handler application, or default install > >>>> > > dir). > > > >>>> > >>>> > >>> That's easy enough to fix within browse.cmd. Although checking specific > >>> version numbers really sucks - CurrentVersion is obviously better. > >>> > >>> You want to just do it or file a bug? > >>> > >>> > >> What I meant is that there is a string telling us the version number, > >> which is then appended to the path to get the final path for the > >> currently installed version . It's piece of cake in decent programming > >> languages, but stupid to do in batch files (probably why it wasn't done > >> in the first place, really). > >> > > > > Where is the string telling us the version number? > > > > I wrote it above: > > "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\CurrentVersion". > > On my system, it contains "3.0.4 (da)", which put together makes: > > "HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\3.0.4 > (da)\Main\PathToExe > > In any way though - now we've gotten rid of the FF profile - we should > simply execute the URL as a "system command" and let the OS forward it > to whatever browser the user has set to default.
No, if Firefox is installed and IE is the default browser, WE SHOULD LAUNCH FIREFOX, because IE has some serious issues with Freenet. > > - Zero3 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20090105/79beb375/attachment.pgp>
