Hello @dschneider-pivotal, I've reworded the javadoc, hope the message is clearer now.
> Also have you looked at these diffs? It seems like some methods that didn't > really change just got moved to a different part of the file. Would it be > possible to move them back so that the actual changes you are making would be > more evident? Given that you have gone back to volatiles it would be nice if > the diffs of the changes only showed things you are actually changing. I moved the methods and attributes around following to this pattern: attribute declarations, getters and setters, constructors, protected and private methods, public methods, inner classes. I' aware that this is just a matter of preference and that currently the `spotless` plugin doesn't take into consideration these patterns, but I'd prefer to keep the order this way, it makes the classes easier to read and maintain. Either way, I can revert them back so only the actual changes are shown in the `diff`, just let me know. [ Full content available at: https://github.com/apache/geode/pull/2250 ] This message was relayed via gitbox.apache.org for [email protected]
