Hmmm... if there is nothing to commit, it might also be fine to ignore the user
commit request? It's a tricky question what to do for this case. Just follow
what the user demands, or be smart? From a correctness point of view, it should
not make a difference, would it?
Also, we set flag `commitRequested` for this case -- thus, it might be better
to put this logic somewhere else? Eg: `AbstractTask` or overwrite in
`StreamTask`:
```
public boolean commitNeeded() {
return commitNeeded || commitRequested;
}
```
(An alternative, that I like less would be to add a check if
`commitRequested==true`)?
[ Full content available at: https://github.com/apache/kafka/pull/5428 ]
This message was relayed via gitbox.apache.org for [email protected]
