Meta comment: Not sure if this is a good argument for inlining in 
general---code might be more readable if it's broken apart is smaller pieces 
and calling methods (with good names) actually self-documents the code. Also, 
shorter methods are easier to understand.

For this particular case, inlining is ok IMHO, as with `if (commitNeeded)` 
check, we don't loose anything.

[ Full content available at: https://github.com/apache/kafka/pull/5428 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to