Yeah, this is another spot where I really struggled with naming. I liked 
`suppress(intermediateEvents())` aka "suppress intermediate events", but the 
version for final would be like "suppress all but final events", and 
`suppress(allButFinalEvents()` just seems too confusing, so I compromised.

Note that this method isn't saying to _emit_ the events, but actually the 
opposite: to _suppress_ them. I think the symmetric name would be 
`suppressIntermediateEvents()`, which looks a little redundant in practice: 
`suppress(suppressIntermediateEvents())` or 
`suppress(Suppressed.suppressIntermediateEvents())` :/

Another idea would be to choose one of the synonyms. Since we are accomplishing 
this suppression via buffering, we could call it `bufferIntermediateEvents` or 
just `buffer`...

Thoughts?

[ Full content available at: https://github.com/apache/kafka/pull/5567 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to