LGTM

On Fri, Sep 14, 2018, 11:21 AM Ahmet Altay <[email protected]> wrote:

> *@aaltay* commented on this pull request.
> ------------------------------
>
> In sdks/go/examples/wordcap/wordcap.go
> <https://github.com/apache/beam/pull/6395#discussion_r217801313>:
>
> > @@ -31,7 +30,7 @@ import (
>  )
>
>  var (
> -     input = flag.String("input", 
> os.ExpandEnv("$GOPATH/src/github.com/apache/beam/sdks/go/data/haiku/old_pond.txt"),
>  "Files to read.")
> +     input = flag.String("input", 
> "gs://apache-beam-samples/shakespeare/kinglear.txt", "File(s) to read.")
>
> Yes, I tried that it does. (This is similar to the wordcount example.) I
> believe this is a public file in GCS and does not require any auth to read
> it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/6395#discussion_r217801313>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ANQ3FRG3B7s3rWyMAMdp0ADaCG-OxQufks5ua_O8gaJpZM4WoYwd>
> .
>


[ Full content available at: https://github.com/apache/beam/pull/6395 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to