Agreed. I'd rather delete them as examples if they're not good at that. Move/change them to be integration tests if they serve a useful purpose that way. The examples should ideally show best practices since things will end up being copy pasted from them all the time. I'd like to see a "getting started with Apache Beam" in Go at some point which can make better/minimal choices as part of a sequence of pipelines. Right now, minimal word count isn't clearly a learning tool.
On Sat, Sep 15, 2018, 10:04 AM Henning Rohde <[email protected]> wrote: > *@herohde* commented on this pull request. > ------------------------------ > > In sdks/go/examples/wordcap/wordcap.go > <https://github.com/apache/beam/pull/6395#discussion_r217890074>: > > > @@ -31,7 +30,7 @@ import ( > ) > > var ( > - input = flag.String("input", > os.ExpandEnv("$GOPATH/src/github.com/apache/beam/sdks/go/data/haiku/old_pond.txt"), > "Files to read.") > + input = flag.String("input", > "gs://apache-beam-samples/shakespeare/kinglear.txt", "File(s) to read.") > > To be clear: I'm fine with these examples being deleted. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/6395#discussion_r217890074>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ANQ3FU8Jx3r_NV8SsTpP1Ar3mQnB9obSks5ubTMEgaJpZM4WoYwd> > . > [ Full content available at: https://github.com/apache/beam/pull/6395 ] This message was relayed via gitbox.apache.org for [email protected]
