@lushuifeng, thanks for the contribution!

Besides setters added to the generated code, are there any changes which 
optimize the generated code, are these setters used somewhere?

Please note, that Drill has its own framework for scalar replacement and 
passing value holders to the methods as arguments may break a scalar 
replacement for those holders.

Also, Drill can generate too large classes. To avoid problems with the class 
constant pool overflow was implemented splitting the classes into the smaller 
ones. Is this change incorporates or at least does not break it?

[ Full content available at: https://github.com/apache/drill/pull/1481 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to