@lushuifeng, thanks, looks great!

But could you please also provide results for JDK and Janino compilers with and 
without this feature.
And it would be good to know the results for other literals, except strings and 
more complex queries.

Are there any cases, where this feature breaks something, or cause performance 
degradation? If no, then no need to provide the option for disabling this 
functionality.

Regarding unit tests, it may be written considering compiler limitation for 
method size - somehow may be passed huge string literals, so query should fail 
without these changes. This test should be sufficient.

[ Full content available at: https://github.com/apache/drill/pull/1481 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to